Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

historical timestamp and db store #355

Merged
merged 6 commits into from
Nov 28, 2024
Merged

Conversation

yoozo
Copy link

@yoozo yoozo commented Nov 26, 2024

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

  • I have tested locally
  • I have performed a self review of my changes
  • Updated any relevant documentation
  • Linked to any relevant issues
  • I have added tests relevant to my changes
  • Any dependent changes have been merged and published in downstream modules
  • My code is up to date with the base branch
  • I have updated relevant changelogs. We suggest using chan

Copy link

github-actions bot commented Nov 26, 2024

Coverage report

Caution

Test run failed

St.
Category Percentage Covered / Total
🔴 Statements 52.19% 3258/6243
🟡 Branches 69.77% 420/602
🔴 Functions 49.29% 139/282
🔴 Lines 52.19% 3258/6243

Test suite run failed

Failed tests: 6/96. Failed suites: 2/14.
  ● eth dictionary v2 › converts ds to v2 dictionary queries

    the method subql_filterBlocksCapabilities does not exist/is not available

      236 |   ): Promise<EthDictionaryV2> {
      237 |     const dictionary = new EthDictionaryV2(endpoint, nodeConfig, project, api);
    > 238 |     await dictionary.init();
          |     ^
      239 |     return dictionary;
      240 |   }
      241 |

      at subqlFilterBlocksCapabilities (node_modules/@subql/node-core/src/indexer/dictionary/v2/dictionaryV2.ts:55:11)
      at EthDictionaryV2.init (node_modules/@subql/node-core/src/indexer/dictionary/v2/dictionaryV2.ts:97:22)
      at Function.create (packages/node/src/indexer/dictionary/v2/ethDictionaryV2.ts:238:5)
      at Object.<anonymous> (packages/node/src/indexer/dictionary/v2/ethDictionaryV2.spec.ts:129:23)

  ● eth dictionary v2 › query response match with entries

    the method subql_filterBlocksCapabilities does not exist/is not available

      236 |   ): Promise<EthDictionaryV2> {
      237 |     const dictionary = new EthDictionaryV2(endpoint, nodeConfig, project, api);
    > 238 |     await dictionary.init();
          |     ^
      239 |     return dictionary;
      240 |   }
      241 |

      at subqlFilterBlocksCapabilities (node_modules/@subql/node-core/src/indexer/dictionary/v2/dictionaryV2.ts:55:11)
      at EthDictionaryV2.init (node_modules/@subql/node-core/src/indexer/dictionary/v2/dictionaryV2.ts:97:22)
      at Function.create (packages/node/src/indexer/dictionary/v2/ethDictionaryV2.ts:238:5)
      at Object.<anonymous> (packages/node/src/indexer/dictionary/v2/ethDictionaryV2.spec.ts:129:23)

  ● eth dictionary v2 › is able to get transaction with field to is null

    the method subql_filterBlocksCapabilities does not exist/is not available

      236 |   ): Promise<EthDictionaryV2> {
      237 |     const dictionary = new EthDictionaryV2(endpoint, nodeConfig, project, api);
    > 238 |     await dictionary.init();
          |     ^
      239 |     return dictionary;
      240 |   }
      241 |

      at subqlFilterBlocksCapabilities (node_modules/@subql/node-core/src/indexer/dictionary/v2/dictionaryV2.ts:55:11)
      at EthDictionaryV2.init (node_modules/@subql/node-core/src/indexer/dictionary/v2/dictionaryV2.ts:97:22)
      at Function.create (packages/node/src/indexer/dictionary/v2/ethDictionaryV2.ts:238:5)
      at Object.<anonymous> (packages/node/src/indexer/dictionary/v2/ethDictionaryV2.spec.ts:129:23)

  ● eth dictionary v2 › is able to query with not null topics

    the method subql_filterBlocksCapabilities does not exist/is not available

      236 |   ): Promise<EthDictionaryV2> {
      237 |     const dictionary = new EthDictionaryV2(endpoint, nodeConfig, project, api);
    > 238 |     await dictionary.init();
          |     ^
      239 |     return dictionary;
      240 |   }
      241 |

      at subqlFilterBlocksCapabilities (node_modules/@subql/node-core/src/indexer/dictionary/v2/dictionaryV2.ts:55:11)
      at EthDictionaryV2.init (node_modules/@subql/node-core/src/indexer/dictionary/v2/dictionaryV2.ts:97:22)
      at Function.create (packages/node/src/indexer/dictionary/v2/ethDictionaryV2.ts:238:5)
      at Object.<anonymous> (packages/node/src/indexer/dictionary/v2/ethDictionaryV2.spec.ts:129:23)

  ● eth dictionary v2 › returns a lastBufferedHeight if there are no block results

    the method subql_filterBlocksCapabilities does not exist/is not available

      236 |   ): Promise<EthDictionaryV2> {
      237 |     const dictionary = new EthDictionaryV2(endpoint, nodeConfig, project, api);
    > 238 |     await dictionary.init();
          |     ^
      239 |     return dictionary;
      240 |   }
      241 |

      at subqlFilterBlocksCapabilities (node_modules/@subql/node-core/src/indexer/dictionary/v2/dictionaryV2.ts:55:11)
      at EthDictionaryV2.init (node_modules/@subql/node-core/src/indexer/dictionary/v2/dictionaryV2.ts:97:22)
      at Function.create (packages/node/src/indexer/dictionary/v2/ethDictionaryV2.ts:238:5)
      at Object.<anonymous> (packages/node/src/indexer/dictionary/v2/ethDictionaryV2.spec.ts:129:23)


  ● rawBlockToEthBlock › successfully converts a block

    TypeError: Cannot read properties of undefined (reading 'blocks')

      52 |   });
      53 |
    > 54 |   return (await res.json()).result.blocks[0];
         |                                    ^
      55 | }
      56 |
      57 | describe('rawBlockToEthBlock', () => {

      at fetchDictionaryBlock (packages/node/src/indexer/dictionary/v2/utils.spec.ts:54:36)
          at async Promise.all (index 0)
      at Object.<anonymous> (packages/node/src/indexer/dictionary/v2/utils.spec.ts:63:23)

  ● rawBlockToEthBlock › can fetch receipts

    TypeError: Cannot read properties of undefined (reading 'blocks')

      52 |   });
      53 |
    > 54 |   return (await res.json()).result.blocks[0];
         |                                    ^
      55 | }
      56 |
      57 | describe('rawBlockToEthBlock', () => {

      at fetchDictionaryBlock (packages/node/src/indexer/dictionary/v2/utils.spec.ts:54:36)
          at async Promise.all (index 0)
      at Object.<anonymous> (packages/node/src/indexer/dictionary/v2/utils.spec.ts:63:23)

Report generated by 🧪jest coverage report action from 35a907f

@yoozo yoozo requested a review from stwiname November 26, 2024 09:04
@@ -19,8 +19,9 @@ import {
} from './block.ethereum';

// Add api key to work
const HTTP_ENDPOINT = 'https://ethereum.rpc.subquery.network/public';
const HTTP_ENDPOINT = 'https://eth-pokt.nodies.app';

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we should be moving away from a subquery RPC. We need to work with the team to figure out what is wrong

@stwiname stwiname merged commit 8644432 into main Nov 28, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants